Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flushing improvements #1502

Merged
merged 7 commits into from
Feb 20, 2020
Merged

Flushing improvements #1502

merged 7 commits into from
Feb 20, 2020

Conversation

mlrawlings
Copy link
Member

Description

  1. Combines components from multiple asyncOut instances into a single init expression per flush.
  2. Combines all scripts per flush using the new out.script helper.
  3. Debounces flushes on a per-tick basis.

These changes should result in less overall code sent to the browser as well as better compression.

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented Feb 14, 2020

Codecov Report

Merging #1502 into master will increase coverage by 0.01%.
The diff coverage is 89.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1502      +/-   ##
==========================================
+ Coverage   90.47%   90.49%   +0.01%     
==========================================
  Files         352      352              
  Lines       12593    12641      +48     
==========================================
+ Hits        11394    11439      +45     
- Misses       1199     1202       +3
Impacted Files Coverage Δ
...core-tags/core/await/client-reorder-runtime.min.js 0% <ø> (ø) ⬆️
src/core-tags/core/await/client-reorder.js 100% <ø> (ø) ⬆️
src/runtime/components/legacy/index.js 88.88% <0%> (ø) ⬆️
src/runtime/html/AsyncStream.js 90.4% <100%> (+1.26%) ⬆️
src/runtime/html/BufferedWriter.js 100% <100%> (+14.28%) ⬆️
src/core-tags/core/await/reorderer-renderer.js 94.11% <100%> (+0.17%) ⬆️
src/core-tags/components/component-globals-tag.js 100% <100%> (ø) ⬆️
src/runtime/html/StringWriter.js 80% <78.57%> (-20%) ⬇️
src/core-tags/components/init-components-tag.js 93.93% <90%> (-0.8%) ⬇️
src/runtime/components/index.js 95.6% <93.33%> (-2.13%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0339255...83c477e. Read the comment docs.

@mlrawlings mlrawlings merged commit 78da58e into master Feb 20, 2020
@DylanPiercey DylanPiercey deleted the flushing-improvements branch February 26, 2020 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant