Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: no such script in packages.json #1932

Closed
lucasgonze opened this issue Apr 17, 2023 · 1 comment
Closed

bug: no such script in packages.json #1932

lucasgonze opened this issue Apr 17, 2023 · 1 comment
Labels
type:unverified bug A bug report that has not been verified

Comments

@lucasgonze
Copy link
Contributor

lucasgonze commented Apr 17, 2023

Marko Version: x.x.x

5.25.5

Details

I have a PR to contribute so I'm running through the guidelines at https://github.com/marko-js/marko/blob/main/.github/CONTRIBUTING.md. The documentation appears to be out of sync with the actual script.

image

On doing npm run test-coverage, I get an error.

Expected Behavior

The script should run.

Actual Behavior

image

Possible Fix

Either the script should exist in package.json or the documentation should be updated. I suspect the correct markdown would be:
Before submitting your PR, make sure that all new and previous tests pass and that [coverage](https://codecov.io/gh/marko-js/marko) has not decreased:

`npm run test`
@lucasgonze lucasgonze added the type:unverified bug A bug report that has not been verified label Apr 17, 2023
@DylanPiercey
Copy link
Contributor

Thanks for the callout, fixed now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:unverified bug A bug report that has not been verified
Projects
None yet
Development

No branches or pull requests

2 participants