Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate w-id/w-for attributes #394

Closed
mlrawlings opened this issue Nov 4, 2016 · 4 comments
Closed

Deprecate w-id/w-for attributes #394

mlrawlings opened this issue Nov 4, 2016 · 4 comments
Assignees
Labels
good first issue Small tasks that would be good for first time contributors scope:components
Milestone

Comments

@mlrawlings
Copy link
Member

mlrawlings commented Nov 4, 2016

The w-id attribute was used to obtain references using this.getEl(refId). w-id has been replaced with the ref attribute.

Renaming these attributes for clarity and because we want to remove references to marko-widgets.

w-idref
w-forfor-ref

I like this because it's more clear that this for-ref will create for that points to the id generated by ref

Old:

<input type="text" w-id="name" />

New:

<input type="text" ref="name" />

Similarly, w-for has been been replaced with for-ref:

Old:

<label w-for="name">Name</label>
<input type="text" w-id="name" />

New:

<label for-ref="name">Name</label>
<input type="text" ref="name" />
@mlrawlings mlrawlings added this to the 4.0 milestone Nov 4, 2016
@patrick-steele-idem patrick-steele-idem changed the title Rename w-* attributes Deprecate w-id/w-for attributes Nov 11, 2016
@patrick-steele-idem patrick-steele-idem added the good first issue Small tasks that would be good for first time contributors label Nov 11, 2016
@ctdio
Copy link
Contributor

ctdio commented Nov 13, 2016

If no one has started working on this, I can take this one up.

@patrick-steele-idem
Copy link
Contributor

@charlieduong94 That would be great if you could take this issue. I invited you as a collaborator so that I can assign this issue to you. You can click the following link to accept: https://github.com/marko-js/marko/invitations

Thanks!

@ctdio
Copy link
Contributor

ctdio commented Nov 13, 2016

PR #427

@patrick-steele-idem
Copy link
Contributor

Work completed. Closing issue. Thanks @charlieduong94 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Small tasks that would be good for first time contributors scope:components
Projects
None yet
Development

No branches or pull requests

3 participants