-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate w-preserve-attrs
#422
Comments
I can take this one. /cc @mlrawlings |
This would be an unlikely case, but do you think we should consolidate <div style:no-update="color:#09c" class="test" w-preserve-attrs="class">
...
</div> <!-- Doesn't matter that it's listed under `class:no-update` and `w-preserve-attrs`. -->
<div style:no-update="color:#09c" class:no-update="test" w-preserve-attrs="class">
...
</div> /cc @mlrawlings What do you think? |
I'm personally leaning toward consolidating because they will function the same anyway. |
@austinkelleher I think consolidation makes the most sense as well. Ideally, this would be done in such a way that the code for My thinking is both <div style:no-update="color:#09c" class="test" w-preserve-attrs="class">
...
</div> and <!-- Doesn't matter that it's listed under `class:no-update` and `w-preserve-attrs`. -->
<div style:no-update="color:#09c" class:no-update="test" w-preserve-attrs="class">
...
</div> Would be transformed to: <div style:no-update="color:#09c" class:no-update="test">
...
</div> And then the code for |
FYI, I've added a new method to do deprecations from the compiler that tracks the node and line:column in the original template code. context.deprecate('deprecation warning text'); |
…reserve-attrs attribute.
…attrs Fixes #422 - Introduce :no-update attribute and deprecate w-preserve-…
w-preserve-attrs
→<input style:no-update=”” title:no-update>
Old:
New:
The text was updated successfully, but these errors were encountered: