Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace fixes #1333

Merged
merged 5 commits into from
May 20, 2019
Merged

Namespace fixes #1333

merged 5 commits into from
May 20, 2019

Conversation

DylanPiercey
Copy link
Contributor

Description

This PR moves the namespaceURI calculation from compile time to runtime which fixes a number of edge cases around the dynamic tag, ambiguous tags, or explicitly setting the xmlns attribute.

Fixes #1098

Also adds support for MathML.

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@coveralls
Copy link

coveralls commented May 15, 2019

Coverage Status

Coverage decreased (-0.01%) to 90.524% when pulling 69dedc6 on namespace-fixes into b82a867 on master.

@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #1333 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1333      +/-   ##
==========================================
+ Coverage   90.53%   90.62%   +0.09%     
==========================================
  Files         340      340              
  Lines       12445    12632     +187     
==========================================
+ Hits        11267    11448     +181     
- Misses       1178     1184       +6
Impacted Files Coverage Δ
src/compiler/ast/HtmlElement/index.js 92.77% <ø> (-0.49%) ⬇️
src/core-tags/components/preserve-tag-browser.js 100% <ø> (ø) ⬆️
...c/compiler/ast/HtmlElement/vdom/HtmlElementVDOM.js 98.14% <100%> (+0.94%) ⬆️
src/runtime/vdom/morphdom/specialElHandlers.js 80.55% <100%> (ø) ⬆️
src/compiler/CompileContext.js 93.54% <100%> (+1.25%) ⬆️
src/runtime/vdom/morphdom/index.js 98.16% <100%> (+0.11%) ⬆️
src/runtime/vdom/AsyncVDOMBuilder.js 92.03% <100%> (-0.12%) ⬇️
src/runtime/vdom/VNode.js 100% <100%> (ø) ⬆️
src/runtime/vdom/VElement.js 97.53% <100%> (+0.29%) ⬆️
src/compiler/config.js 71.42% <0%> (-3.58%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b82a867...69dedc6. Read the comment docs.

@DylanPiercey DylanPiercey merged commit e065c14 into master May 20, 2019
@DylanPiercey DylanPiercey deleted the namespace-fixes branch July 8, 2019 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic svg elements not mounted correctly
2 participants