Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tryonline: correct paths and no taglibImports #1360

Merged
merged 2 commits into from Jun 24, 2019
Merged

Conversation

mlrawlings
Copy link
Member

Description

Fixes some incorrect paths and directly registers the taglibs. These changes are necessary for Try Online to work.

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented Jun 18, 2019

Codecov Report

Merging #1360 into master will increase coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1360      +/-   ##
=========================================
+ Coverage   90.49%   90.5%   +<.01%     
=========================================
  Files         341     341              
  Lines       12489   12495       +6     
=========================================
+ Hits        11302   11308       +6     
  Misses       1187    1187
Impacted Files Coverage Δ
src/core-tags/components/helpers/bindComponent.js 0% <0%> (ø) ⬆️
src/runtime/components/legacy/dependencies/vdom.js 0% <0%> (ø) ⬆️
src/compiler/index.js 79.23% <100%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 216e257...09a8216. Read the comment docs.

@coveralls
Copy link

coveralls commented Jun 18, 2019

Coverage Status

Coverage increased (+0.005%) to 90.5% when pulling 09a8216 on fix-try-online into 216e257 on master.

@mlrawlings mlrawlings merged commit e4d8677 into master Jun 24, 2019
@DylanPiercey DylanPiercey deleted the fix-try-online branch July 8, 2019 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants