Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with invoke tag that has control flow #1366

Merged
merged 1 commit into from Jun 26, 2019

Conversation

DylanPiercey
Copy link
Contributor

Description

Currently there is a bug with the invoke tag migration where it will incorrectly read the attributes before they are normalized by the common transformers.

This causes an issue where an invoke tag contains control flow:

<invoke if(x) y()/>

Which will error at compile time before this fix.

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.591% when pulling b7fafdd on invoke-tag-with-control-flow into b264a27 on master.

@codecov
Copy link

codecov bot commented Jun 26, 2019

Codecov Report

Merging #1366 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1366   +/-   ##
=======================================
  Coverage   90.59%   90.59%           
=======================================
  Files         341      341           
  Lines       12467    12467           
=======================================
  Hits        11294    11294           
  Misses       1173     1173
Impacted Files Coverage Δ
src/core-tags/migrate/invoke-tag.js 83.33% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b264a27...b7fafdd. Read the comment docs.

@DylanPiercey DylanPiercey merged commit 3c6c851 into master Jun 26, 2019
@DylanPiercey DylanPiercey deleted the invoke-tag-with-control-flow branch July 8, 2019 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants