Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate and add migrator for top level named classes #1372

Merged
merged 1 commit into from Jul 3, 2019

Conversation

DylanPiercey
Copy link
Contributor

Description

Adds a deprecation and migration for named top level classes.

class x {
}

<div/>

becomes:

class {
}

<div/>

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented Jul 2, 2019

Codecov Report

Merging #1372 into master will decrease coverage by <.01%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1372      +/-   ##
==========================================
- Coverage   90.59%   90.58%   -0.01%     
==========================================
  Files         341      343       +2     
  Lines       12467    12476       +9     
==========================================
+ Hits        11294    11302       +8     
- Misses       1173     1174       +1
Impacted Files Coverage Δ
src/core-tags/components/class-tag-transformer.js 100% <100%> (ø)
src/core-tags/components/class-tag-node-factory.js 100% <100%> (ø)
src/core-tags/migrate/class-tag.js 87.5% <87.5%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 535daf9...6d70aa1. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.001%) to 90.59% when pulling 6d70aa1 on migrate-top-level-named-class into 535daf9 on master.

@mlrawlings mlrawlings merged commit c3444fb into master Jul 3, 2019
@DylanPiercey DylanPiercey deleted the migrate-top-level-named-class branch July 8, 2019 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants