Fix issue with tracking components for client-reorder await tags #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1375 +/- ##
==========================================
- Coverage 90.59% 90.58% -0.01%
==========================================
Files 341 341
Lines 12467 12466 -1
==========================================
- Hits 11294 11292 -2
- Misses 1173 1174 +1
Continue to review full report at Codecov.
|
mlrawlings
approved these changes
Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the
ComponentsContextis not forwarded when using an<await client-reorder>tag.This PR ensures that
awaittags withclient-reorderare tracked accordingly which ensures more reliable keys, fixes some issues with hooking up events for split components and fixes some runtime errors that could occur if nestingawaittags without components in between them.This PR also contains a
bonus change™️ which ensures that when creating new AST nodes while copying over body content from another node that the children properly track their new parent node. This fixes some issues with migrations which rely on this and also walk up the ast in some cases.Checklist: