Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dynamic string attributes in vdom and add deprecation… #1378

Merged
merged 1 commit into from Jul 8, 2019

Conversation

DylanPiercey
Copy link
Contributor

Description

Adds back and deprecates support for passing a string as dynamic attributes in the vdom (improved Marko v3 Compatibility).

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented Jul 3, 2019

Codecov Report

Merging #1378 into master will increase coverage by <.01%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1378      +/-   ##
==========================================
+ Coverage   90.58%   90.59%   +<.01%     
==========================================
  Files         344      344              
  Lines       12483    12501      +18     
==========================================
+ Hits        11308    11325      +17     
- Misses       1175     1176       +1
Impacted Files Coverage Δ
src/runtime/html/helper-attrs.js 100% <100%> (ø) ⬆️
src/runtime/vdom/helper-attrs.js 96.42% <93.33%> (-3.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb4935a...a578bce. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 90.593% when pulling a578bce on dynamic-str-attrs-vdom into cb4935a on master.

@DylanPiercey DylanPiercey merged commit ffe5853 into master Jul 8, 2019
@DylanPiercey DylanPiercey deleted the dynamic-str-attrs-vdom branch July 8, 2019 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants