Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression with container nodes #1380

Merged
merged 1 commit into from Jul 8, 2019
Merged

Conversation

DylanPiercey
Copy link
Contributor

Description

Fixes a regression from https://github.com/marko-js/marko/pull/1375/files#diff-73897f1fa5eecec95203fcfbe9e5832eR112. It turns out that the existing behavior of using the same container node instance is relied on and that change causes some nodes to act as if they were removed.

This PR fixes the regression by reusing the array container instance and just changing the owner node.

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented Jul 8, 2019

Codecov Report

Merging #1380 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1380      +/-   ##
==========================================
- Coverage   90.59%   90.59%   -0.01%     
==========================================
  Files         342      342              
  Lines       12495    12494       -1     
==========================================
- Hits        11320    11319       -1     
  Misses       1175     1175
Impacted Files Coverage Δ
src/compiler/ast/Node.js 96.27% <100%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d92c43b...7721490. Read the comment docs.

@DylanPiercey DylanPiercey merged commit 77d76aa into master Jul 8, 2019
@DylanPiercey DylanPiercey deleted the container-node-regression branch July 8, 2019 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant