Fix regression with container nodes #1380
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a regression from https://github.com/marko-js/marko/pull/1375/files#diff-73897f1fa5eecec95203fcfbe9e5832eR112. It turns out that the existing behavior of using the same container node instance is relied on and that change causes some nodes to act as if they were removed.
This PR fixes the regression by reusing the array container instance and just changing the owner node.
Checklist: