Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support components that contain <html>/<!doctype> #1428

Merged
merged 1 commit into from Oct 17, 2019
Merged

support components that contain <html>/<!doctype> #1428

merged 1 commit into from Oct 17, 2019

Conversation

mlrawlings
Copy link
Member

Description

Fixes #1290

This now works:

class {
  onCreate() {
    this.state = { count:0 }
  }
  increment() {
    this.state.count++;
  }
}

<!doctype html>
<html>
<head>
  <title>${state.count}</title>
</head>
<body>
  <h1>Hello ${state.count}</h1>
  <button on-click("increment")>increment</button>
</body>
</html>

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@coveralls
Copy link

coveralls commented Oct 17, 2019 •
edited

Coverage Status

Coverage increased (+0.08%) to 90.63% when pulling 5e6e1aa on root-components into a85f042 on master.

@codecov
Copy link

codecov bot commented Oct 17, 2019 •
edited

Codecov Report

Merging #1428 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1428      +/-   ##
==========================================
+ Coverage   90.55%   90.55%   +<.01%     
==========================================
  Files         343      343              
  Lines       12542    12546       +4     
==========================================
+ Hits        11357    11361       +4     
  Misses       1185     1185
Impacted Files Coverage Δ
src/runtime/vdom/morphdom/index.js 97.72% <100%> (+0.02%) ⬆️
src/runtime/vdom/morphdom/fragment.js 95.34% <100%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a85f042...5e6e1aa. Read the comment docs.

@mlrawlings mlrawlings mentioned this pull request Oct 17, 2019
Closed
3 tasks
@DylanPiercey DylanPiercey merged commit 98d2702 into master Oct 17, 2019
@tigt tigt mentioned this pull request Oct 23, 2019
Closed
@DylanPiercey DylanPiercey mentioned this pull request Feb 4, 2020
Closed
@mlrawlings mlrawlings deleted the root-components branch February 25, 2020 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DylanPiercey DylanPiercey DylanPiercey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't have a stateful component in root page
3 participants
@mlrawlings @coveralls @DylanPiercey