Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: all vnodes have owner components #1517

Merged
merged 2 commits into from Feb 27, 2020
Merged

Conversation

mlrawlings
Copy link
Member

Description

VText nodes (all all vnodes for that matter) now have an owner component or a parent with the same owner component (static subtrees only have an owner component on the root node).

This is needed for own owner tree snapshot tool that's been in progress for a while now.

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

Merging #1517 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1517      +/-   ##
==========================================
- Coverage   90.55%   90.49%   -0.07%     
==========================================
  Files         353      353              
  Lines       12718    12675      -43     
==========================================
- Hits        11517    11470      -47     
- Misses       1201     1205       +4
Impacted Files Coverage Δ
...te/all-templates/non-standard-template-literals.js 100% <100%> (ø) ⬆️
packages/marko/src/runtime/components/index.js 95.55% <100%> (-3.68%) ⬇️
packages/marko/src/compiler/Walker.js 92.5% <0%> (-1.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbf0a8a...2ba8cda. Read the comment docs.

@DylanPiercey DylanPiercey merged commit cb42609 into master Feb 27, 2020
DylanPiercey pushed a commit that referenced this pull request Feb 27, 2020
@DylanPiercey DylanPiercey deleted the vnode-owner-component branch March 2, 2020 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants