Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with keys under ssr no-update root #1527

Merged
merged 2 commits into from
Mar 10, 2020

Conversation

DylanPiercey
Copy link
Contributor

Description

This PR fixes two issues.

  1. fix: don't serialize component boundary keys if the owner isn't hydrated #1525 caused a regression which prevented adding keys for boundary components with no-update content.
  2. Fixes an issue where keyed items under for a stateful component under a no-update section were not being registered.

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #1527 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1527      +/-   ##
=========================================
+ Coverage   90.49%   90.5%   +<.01%     
=========================================
  Files         353     353              
  Lines       12690   12695       +5     
=========================================
+ Hits        11484   11489       +5     
  Misses       1206    1206
Impacted Files Coverage Δ
packages/marko/src/runtime/components/dom-data.js 50% <ø> (ø) ⬆️
...ges/marko/src/runtime/components/beginComponent.js 100% <100%> (ø) ⬆️
.../src/runtime/components/init-components-browser.js 83.04% <100%> (-0.2%) ⬇️
packages/marko/src/runtime/components/Component.js 95.87% <100%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a43266...4092ea4. Read the comment docs.

@DylanPiercey DylanPiercey merged commit fd03031 into master Mar 10, 2020
@DylanPiercey DylanPiercey deleted the nested-no-update-keyed-fixes branch March 10, 2020 00:23
DylanPiercey added a commit that referenced this pull request Apr 13, 2020
Co-authored-by: Michael Rawlings <mirawlings@ebay.com>
(cherry picked from commit fd03031)
DylanPiercey added a commit that referenced this pull request Apr 13, 2020
Co-authored-by: Michael Rawlings <mirawlings@ebay.com>
(cherry picked from commit fd03031)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants