Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve a few small things legacy compatibility #1545

Merged
merged 1 commit into from
Apr 10, 2020

Conversation

DylanPiercey
Copy link
Contributor

Description

Fixes three small issues:

  1. The w-bind migrator would normalize w-bind="./index" to w-bind="./" which was not safe if you had a package.json in the same folder with a main field.
  2. widgetConfig was being incorrectly merged into the component instance (as well as being available on this.widgetConfig. This is a regression from perf: optimize serializing renderBody & legacy widgets #1539
  3. Previously in Marko 3 template.render with a callback would provide out as the third argument. This has been added back for compatibility.

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented Apr 10, 2020

Codecov Report

Merging #1545 into master will not change coverage by %.
The diff coverage is 75.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1545   +/-   ##
=======================================
  Coverage   90.53%   90.53%           
=======================================
  Files         356      356           
  Lines       12769    12769           
=======================================
  Hits        11561    11561           
  Misses       1208     1208           
Impacted Files Coverage Δ
...ges/marko/src/core-tags/migrate/all-tags/w-bind.js 88.37% <50.00%> (ø)
...kages/marko/src/runtime/components/ComponentDef.js 98.73% <100.00%> (ø)
packages/marko/src/runtime/renderable.js 96.77% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db56ff9...f0d4de4. Read the comment docs.

@DylanPiercey DylanPiercey merged commit 72e716e into master Apr 10, 2020
@DylanPiercey DylanPiercey deleted the legacy-compat-fixes-04-10-2020 branch April 10, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant