improvement: add support for split component lazy hydration #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DylanPiercey
reviewed
Dec 7, 2020
There was a problem hiding this comment.
Thanks again @mcferrenm for taking the time to make this PR.
The majority of the comments I have seem to be related to making your original changes based off of Marko 4. It seems a bunch of unnecessary changes made it in because of that.
Besides that theres just a few nit picks. 😄
packages/marko/src/runtime/components/init-components-browser.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Max McFerren <mmcferren@ebay.com>:
DylanPiercey
force-pushed
the
lazy-hydration
branch
from
9884799
to
17dfde3
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist: