Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marko 5: Fix repeated render body #1635

Merged
merged 2 commits into from
Dec 8, 2020

Conversation

DylanPiercey
Copy link
Contributor

Description

Fixes issue where dynamic attribute tags are used with default body content.

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented Dec 8, 2020

Codecov Report

Merging #1635 (90c9927) into next (9d31667) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1635      +/-   ##
==========================================
+ Coverage   90.46%   90.49%   +0.03%     
==========================================
  Files         217      217              
  Lines        6567     6588      +21     
==========================================
+ Hits         5941     5962      +21     
  Misses        626      626              
Impacted Files Coverage Δ
...ckages/translator-default/src/tag/attribute-tag.js 100.00% <100.00%> (ø)
packages/translator-default/src/tag/util.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d31667...90c9927. Read the comment docs.

@DylanPiercey DylanPiercey merged commit 6c33c0f into next Dec 8, 2020
@DylanPiercey DylanPiercey deleted the next-render-body-with-dynamic-attrs branch December 8, 2020 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant