Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: loosen babel parse errors #1918

Merged
merged 1 commit into from
Mar 21, 2023
Merged

fix: loosen babel parse errors #1918

merged 1 commit into from
Mar 21, 2023

Conversation

DylanPiercey
Copy link
Contributor

Description

Reduce script parsing restrictions added by Babel.
This was causing Babel to error when parsing partion scripts.

static const x = 1;
export { x };

Before this change in the above code Babel would error when parsing export { x } saying x was not previously defined. This is because Marko parses these statements in isolation.

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Mar 21, 2023

🦋 Changeset detected

Latest commit: 601a657

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@marko/translator-default Patch
@marko/compiler Patch
marko Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DylanPiercey DylanPiercey merged commit cceab7d into main Mar 21, 2023
@DylanPiercey DylanPiercey deleted the ease-babel-parse-options branch March 21, 2023 18:00
@github-actions github-actions bot mentioned this pull request Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant