Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hydration native tag no-update issue #2205

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

DylanPiercey
Copy link
Contributor

Description

Fixes an issue where native tags would fail to hydrate in some cases if there was a diffing mismatch because they did not have their server key serialized.

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented Apr 15, 2024

🦋 Changeset detected

Latest commit: 83d5160

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
marko Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DylanPiercey DylanPiercey merged commit af4adcd into main Apr 15, 2024
7 checks passed
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.34%. Comparing base (11acdf6) to head (83d5160).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2205   +/-   ##
=======================================
  Coverage   87.34%   87.34%           
=======================================
  Files         326      326           
  Lines       32146    32146           
  Branches     1619     1619           
=======================================
  Hits        28079    28079           
  Misses       4052     4052           
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DylanPiercey DylanPiercey deleted the fix-no-update-native-tag-key branch April 15, 2024 22:14
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant