Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export individual signals from child components #2234

Merged
merged 1 commit into from
May 17, 2024

Conversation

mlrawlings
Copy link
Member

@mlrawlings mlrawlings commented May 17, 2024

Description

Exports aliases to input so we can call them directly from parent components (soon)

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented May 17, 2024

⚠️ No Changeset found

Latest commit: e79354f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 96.87500% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 87.68%. Comparing base (d2b973c) to head (e79354f).

Files Patch % Lines
...ages/translator-tags/src/visitors/program/index.ts 95.23% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2234      +/-   ##
==========================================
+ Coverage   87.67%   87.68%   +0.01%     
==========================================
  Files         332      332              
  Lines       33467    33524      +57     
  Branches     1785     1796      +11     
==========================================
+ Hits        29341    29395      +54     
- Misses       4112     4115       +3     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlrawlings mlrawlings merged commit 0434cea into main May 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant