Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stale closure bug #2240

Merged
merged 3 commits into from
May 31, 2024
Merged

Stale closure bug #2240

merged 3 commits into from
May 31, 2024

Conversation

mlrawlings
Copy link
Member

Description

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented May 31, 2024

🦋 Changeset detected

Latest commit: f899655

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@marko/runtime-tags Patch
@marko/translator-tags Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 89.28571% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 87.48%. Comparing base (da90eab) to head (49ddf81).

Files Patch % Lines
packages/translator-tags/src/core/for.ts 88.46% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2240      +/-   ##
==========================================
+ Coverage   87.45%   87.48%   +0.02%     
==========================================
  Files         333      333              
  Lines       33832    33838       +6     
  Branches     1851     1860       +9     
==========================================
+ Hits        29587    29602      +15     
+ Misses       4234     4225       -9     
  Partials       11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlrawlings mlrawlings merged commit a6bac65 into main May 31, 2024
5 checks passed
@github-actions github-actions bot mentioned this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants