Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle uncaught errors, support timeout attr #13

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

DylanPiercey
Copy link
Contributor

Description

  • Forward errors that happen before the query into the error property.
  • Ensure errors are serialized properly to the browser.
  • Add support for overriding the builtin timeout attribute of the <await>.

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage: 88.37% and project coverage change: -0.29% ⚠️

Comparison is base (7e4d800) 81.21% compared to head (1f96347) 80.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   81.21%   80.93%   -0.29%     
==========================================
  Files          12       12              
  Lines         181      215      +34     
  Branches       18       25       +7     
==========================================
+ Hits          147      174      +27     
- Misses         23       29       +6     
- Partials       11       12       +1     
Files Changed Coverage Δ
src/components/gql-query/impl/browser.marko 100.00% <ø> (ø)
.../gql-query/components/gql-query-client/index.marko 69.11% <86.48%> (+6.95%) ⬆️
src/components/gql-query/impl/server.marko 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DylanPiercey DylanPiercey merged commit 5479d3a into main Jul 26, 2023
4 of 5 checks passed
@DylanPiercey DylanPiercey deleted the improve-errors branch July 26, 2023 22:24
@github-actions
Copy link

🎉 This PR is included in version 2.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant