feat: move nested browser remaps to internal node_modules #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DylanPiercey
force-pushed
the
support-vite
branch
from
5434968
to
79e229c
Compare
DylanPiercey
force-pushed
the
support-vite
branch
from
79e229c
to
db5ab57
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
==========================================
+ Coverage 79.45% 84.05% +4.60%
==========================================
Files 12 5 -7
Lines 219 69 -150
Branches 26 4 -22
==========================================
- Hits 174 58 -116
+ Misses 34 6 -28
+ Partials 11 5 -6 ☔ View full report in Codecov by Sentry. |
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an alternative to #16
Specifically this avoids using arbitrary nested
package.jsonfor remapping browser files and instead creates "internal node_modules" to do this.Dev tooling often don't like this approach and so it required quite a few changes.
This PR also updates all modules.