replace window.load with DOMContentLoaded #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Night mode toggle button is rendered only when page is fully loaded because of `window.load`. WP has lots of scripts that delay page loading. To solve this `DOMContentLoaded` should be used which is fired when HTML is parsed thus allowing to render the toggle almost immediately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Night mode toggle button is rendered only when page is fully loaded because of
window.load. WP has lots of scripts that delay page loading. To solve thisDOMContentLoadedshould be used which is fired when HTML is parsed thus allowing to render the toggle almost immediately.