Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category methods on Client #7

Merged
merged 5 commits into from
Jun 13, 2013
Merged

Category methods on Client #7

merged 5 commits into from
Jun 13, 2013

Conversation

jamlen
Copy link
Collaborator

@jamlen jamlen commented Jun 12, 2013

Added category(id_or_name) and categories methods to Client. Started refactor of the specs, not finished but let me know what you think so I don't waste loads of time!

…iles.

- Breaking large 'it' specs into smaller 'its' making use of implicit subjects and one-liners.
- Adding .rspec to always require 'spec_helper', give colour for Mac OS X terminal and documentation format when not run through Guard.
- Updated Guardfile to correctly monitor source code in lib/kickscraper and subfolders.
… method alias for more_projects_available? which feels more 'ruby-ish'.
@jamlen jamlen mentioned this pull request Jun 12, 2013
@jamlen
Copy link
Collaborator Author

jamlen commented Jun 12, 2013

Fixed the merge conflicts by deleting the spec/lib/kickscraper_spec.rb and ensuring that spec/client_spec.rb has the extra specs from @benrugg commit.

@markolson
Copy link
Owner

Ooh, and paging thrown in for free. I'll play with this tonight, if @benrugg can't look at it before then.

@benrugg
Copy link
Collaborator

benrugg commented Jun 12, 2013

Awesome. I'm so excited to have more collaboration on this. And thanks for cleaning up my tests... they were definitely starting to feel clunky.

I would love to check this out right now, but I'm running out the door. Hopefully @markolson can check it out before I get to it.

@jamlen
Copy link
Collaborator Author

jamlen commented Jun 13, 2013

Regarding the specs, I've been reading through RSpec Best Practices which has some interesting points and am looking at adopting some shared examples especially for it_behaves_like "a collection of Projects" to remove lots of the duplication in the client_spec.rb.

@benrugg
Copy link
Collaborator

benrugg commented Jun 13, 2013

Hey @jamlen, I just had a chance to check through this, and it all looks really good. I'm so glad that you improved the tests the way you did. Honestly, I would have loved to have done that myself, but I'm just starting to learn RSpec well enough to do that.

If you're up for it, definitely add it_behaves_like "a collection of Projects" like you mentioned!

benrugg pushed a commit that referenced this pull request Jun 13, 2013
Category methods on Client, and improved specs
@benrugg benrugg merged commit 856cb82 into markolson:master Jun 13, 2013
@benrugg
Copy link
Collaborator

benrugg commented Jun 13, 2013

Also, @jamlen... between your work and the "paging" that I added, I say it's time to bump the version to 0.0.4 :-)

@benrugg
Copy link
Collaborator

benrugg commented Jun 13, 2013

Hey @jamlen, while I'm still thinking about it, something that would be nice in the categories is seeing whether a category is a parent category or not. And other related functionality like being able to get its child categories, or get a child's parent category, etc.

I don't need that for my project, so I probably won't work on it, but I thought I'd throw it out there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants