-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Category methods on Client #7
Conversation
…iles. - Breaking large 'it' specs into smaller 'its' making use of implicit subjects and one-liners. - Adding .rspec to always require 'spec_helper', give colour for Mac OS X terminal and documentation format when not run through Guard. - Updated Guardfile to correctly monitor source code in lib/kickscraper and subfolders.
… method alias for more_projects_available? which feels more 'ruby-ish'.
Conflicts: spec/lib/kickscraper_spec.rb
Fixed the merge conflicts by deleting the |
Ooh, and paging thrown in for free. I'll play with this tonight, if @benrugg can't look at it before then. |
Awesome. I'm so excited to have more collaboration on this. And thanks for cleaning up my tests... they were definitely starting to feel clunky. I would love to check this out right now, but I'm running out the door. Hopefully @markolson can check it out before I get to it. |
…ce the body directly.
Regarding the specs, I've been reading through RSpec Best Practices which has some interesting points and am looking at adopting some shared examples especially for |
Hey @jamlen, I just had a chance to check through this, and it all looks really good. I'm so glad that you improved the tests the way you did. Honestly, I would have loved to have done that myself, but I'm just starting to learn RSpec well enough to do that. If you're up for it, definitely add |
Category methods on Client, and improved specs
Also, @jamlen... between your work and the "paging" that I added, I say it's time to bump the version to 0.0.4 :-) |
Hey @jamlen, while I'm still thinking about it, something that would be nice in the categories is seeing whether a category is a parent category or not. And other related functionality like being able to get its child categories, or get a child's parent category, etc. I don't need that for my project, so I probably won't work on it, but I thought I'd throw it out there. |
Added category(id_or_name) and categories methods to Client. Started refactor of the specs, not finished but let me know what you think so I don't waste loads of time!