Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored setup script with pyenv support #21

Merged
merged 8 commits into from Nov 24, 2019

Conversation

markosamuli
Copy link
Owner

@markosamuli markosamuli commented Nov 23, 2019

Setup script:

  • Rework on the setup script for improved Ansible installation when using pyenv or virtualenv or calling Ansible with any non-system paths.
  • Use /bin/bash executable instead of /bin/sh with Ansible on WSL environments to get around Windows directory white spaces on the PATH. Fixes issues with zzet.rbenv role no longer using bash for executing shell commands.

Role scripts:

  • Added clean-roles.py script for removing outdated Ansible roles.
  • Fix update-roles.py script not working if using master as version in requirements.yml file.

Makefile:

  • Added setup command for running setup script with the default options.
  • Removed setup-ansible and setup-ansible-pypi Makefile commands.
  • Added install-ansible Makefile command that doesn't enable or disable PyPI and doesn't reinstall existing Ansible installations.
  • Playbook short commands in Makefile will automatically install missing Ansible roles.
  • Added linuxbrew Makefile command.
  • Renamed roles Makefile command to install-roles and removed -f argument.
  • Renamed update Makefile command to update-roles.
  • Added clean-roles Makefile command for running clean-roles.py script.
  • Added latest-roles Makefile command to update, clean and install required Ansible roles to their latest versions.

Development environment:

  • Move development requirements from requirements.txt into a separate requirements.dev.txt file to avoid installing those during normal usage.

Makefile tasks to run Ansible playbooks will install missing roles
automatically before running the playbooks.
Fixes issues with zzet.rbenv role when trying to use rbenv with sh
shell on WSL with Windows paths with spaces on the PATH.
Additional options for enabling and disabling Ansible installation
options.

Support for installing into the local pyenv development environment.

Split requirements.txt and requirements.dev.txt files.
@markosamuli markosamuli force-pushed the feature/setup-with-pyenv-support branch from e578c1c to 93e22e4 Compare November 23, 2019 23:17
@markosamuli markosamuli force-pushed the feature/setup-with-pyenv-support branch from 1648cae to 26b79fd Compare November 23, 2019 23:47
@markosamuli markosamuli merged commit 11cc4f7 into develop Nov 24, 2019
@markosamuli markosamuli deleted the feature/setup-with-pyenv-support branch January 31, 2020 21:08
@markosamuli markosamuli restored the feature/setup-with-pyenv-support branch January 31, 2020 21:08
@markosamuli markosamuli deleted the feature/setup-with-pyenv-support branch January 31, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant