Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3gp, 3gpp preference is "video/3gpp" #7

Closed
Rikkuru opened this issue Apr 14, 2021 · 4 comments
Closed

3gp, 3gpp preference is "video/3gpp" #7

Rikkuru opened this issue Apr 14, 2021 · 4 comments

Comments

@Rikkuru
Copy link

Rikkuru commented Apr 14, 2021

3GPP can use audio and video but video will be better when we don't know the content.
https://tools.ietf.org/html/rfc3839#section-3.2

The type "video/3gpp" is valid for all files.  It is valid to serve an audio-only file as "video/3gpp".
@markov2
Copy link
Owner

markov2 commented Apr 14, 2021

Are you going through all 2965 types? Wow!

@markov2 markov2 closed this as completed Apr 14, 2021
markov2 added a commit that referenced this issue Apr 14, 2021
@markov2
issue #7 3gp, 3gpp preference is "video/3gpp"
6c4d3cc
@Rikkuru
Copy link
Author

Rikkuru commented Apr 14, 2021

no ) i had tests on this ones that broke after update

@markov2
Copy link
Owner

markov2 commented Apr 14, 2021

Sorry for the breakage. Guessing mime-type based on file-name extension is a risky business. You made it a little safer ;-)

@Rikkuru
Copy link
Author

Rikkuru commented Apr 14, 2021

Thank you for quick response !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markov2 @Rikkuru