Skip to content
This repository has been archived by the owner on Sep 11, 2023. It is now read-only.

include weights in tICA #749

Closed
euhruska opened this issue Mar 29, 2016 · 8 comments
Closed

include weights in tICA #749

euhruska opened this issue Mar 29, 2016 · 8 comments

Comments

@euhruska
Copy link

Is it possible to add including weights when calculating tICA from multiple trajectories? Each trajectory would have different (non-integer) weights.

@gph82
Copy link
Contributor

gph82 commented Mar 30, 2016

Hi, can you be a bit more specific as to what will happen to the transformed trajectories once you computed your weighted TICA transformation? Normal discretization plus MSM, like in the example notebooks?

@euhruska
Copy link
Author

no MSM, at least, I don't plan to. I want to do then a reweighting step similar to DM-d-MD. That's why the weights are quite important. For that, I only need the TICA coordinates of the points along the trajectories.

@gph82
Copy link
Contributor

gph82 commented Mar 30, 2016

I am not familiar with the new running_covar class, perhaps one could provide it with an array of trajectory weights at initialization and then set return_trajindex = True for this iterator
https://github.com/markovmodel/PyEMMA/blob/devel/pyemma/coordinates/transform/tica.py#L264
and parse that trajindex to self._covar.add here:
https://github.com/markovmodel/PyEMMA/blob/devel/pyemma/coordinates/transform/tica.py#L268

but I am not sure if the running_moments algorithm assumes equal weights. What do you think, @franknoe

@franknoe
Copy link
Contributor

Don't worry, I'll do it. I just told Eugen to open an issue so that I
don't forget.

Am 30/03/16 um 18:07 schrieb Guillermo Pérez-Hernández:

I am not familiar with the new running_covar class, perhaps one could
provide it with an array of trajectory weights at initialization and
then set |return_trajindex = True| for this iterator
https://github.com/markovmodel/PyEMMA/blob/devel/pyemma/coordinates/transform/tica.py#L264
and parse that trajindex to |self._covar.add| here:
https://github.com/markovmodel/PyEMMA/blob/devel/pyemma/coordinates/transform/tica.py#L268

but I am not sure if the running_moments algorithm assumes equal
weights. What do you think, @franknoe https://github.com/franknoe


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#749 (comment)


Prof. Dr. Frank Noe
Head of Computational Molecular Biology group
Freie Universitaet Berlin

Phone: (+49) (0)30 838 75354
Web: research.franknoe.de

Mail: Arnimallee 6, 14195 Berlin, Germany

@marscher
Copy link
Member

Isn't that just a duplicate of #570?

@franknoe
Copy link
Contributor

It is indeed!
Feliks is currently working on that.

Am 17/05/16 um 20:18 schrieb Martin K. Scherer:

Isn't that just a duplicate of #570
#570?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#749 (comment)


Prof. Dr. Frank Noe
Head of Computational Molecular Biology group
Freie Universitaet Berlin

Phone: (+49) (0)30 838 75354
Web: research.franknoe.de

Mail: Arnimallee 6, 14195 Berlin, Germany

@marscher
Copy link
Member

marscher commented May 17, 2016 via email

@marscher
Copy link
Member

I think we have this now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants