Skip to content
This repository has been archived by the owner on Sep 11, 2023. It is now read-only.

[CKTest] copy test model to avoid side effects. #1255

Merged
merged 2 commits into from Feb 21, 2018

Conversation

thempel
Copy link
Member

@thempel thempel commented Feb 19, 2018

Somehow the propagation of the test models
transition matrix induces side effects on the model.

Fixes #1254

Somehow the propagation of the test models
transition matrix induces side effects on the model.
@thempel
Copy link
Member Author

thempel commented Feb 19, 2018

@marscher thanks a lot!!

@codecov
Copy link

codecov bot commented Feb 20, 2018

Codecov Report

Merging #1255 into devel will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel    #1255      +/-   ##
==========================================
+ Coverage   91.22%   91.23%   +0.01%     
==========================================
  Files         219      219              
  Lines       23766    23767       +1     
==========================================
+ Hits        21681    21685       +4     
+ Misses       2085     2082       -3
Impacted Files Coverage Δ
pyemma/msm/estimators/lagged_model_validators.py 78.85% <100%> (+0.12%) ⬆️
pyemma/coordinates/transform/vamp.py 91.53% <0%> (+0.38%) ⬆️
pyemma/coordinates/data/util/traj_info_backends.py 92.48% <0%> (+0.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1692755...cd30250. Read the comment docs.

@marscher
Copy link
Member

I think we should investigate, which side-effect in MSM actually caused this, since it might be an issue in other spots too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants