Skip to content
This repository has been archived by the owner on Sep 11, 2023. It is now read-only.

Tica base class to avoid copy paste code #1273

Merged
merged 4 commits into from
Mar 19, 2018

Conversation

marscher
Copy link
Member

@marscher marscher commented Mar 8, 2018

TICA and Nystroem-TICA now share a base class to avoid double implementation.

@codecov
Copy link

codecov bot commented Mar 8, 2018

Codecov Report

Merging #1273 into devel will increase coverage by 0.16%.
The diff coverage is 91.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel    #1273      +/-   ##
==========================================
+ Coverage   88.17%   88.33%   +0.16%     
==========================================
  Files         223      224       +1     
  Lines       24744    24728      -16     
==========================================
+ Hits        21818    21844      +26     
+ Misses       2926     2884      -42
Impacted Files Coverage Δ
pyemma/coordinates/tests/test_nystroem_tica.py 99.18% <100%> (+0.02%) ⬆️
pyemma/coordinates/tests/test_tica.py 99.33% <100%> (ø) ⬆️
pyemma/coordinates/transform/tica.py 90% <100%> (+1.25%) ⬆️
pyemma/coordinates/transform/nystroem_tica.py 91.97% <87.17%> (+10.72%) ⬆️
pyemma/coordinates/transform/_tica_base.py 91.39% <91.39%> (ø)
pyemma/coordinates/api.py 88.21% <0%> (+0.35%) ⬆️
pyemma/coordinates/data/util/traj_info_backends.py 92.48% <0%> (+0.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 888e037...06081c5. Read the comment docs.

@marscher marscher merged commit 04ade4d into markovmodel:devel Mar 19, 2018
@marscher marscher deleted the tica_base_class branch March 19, 2018 10:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant