Skip to content
This repository has been archived by the owner on Sep 11, 2023. It is now read-only.

Improved topology LRU cache #1545

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Improved topology LRU cache #1545

merged 1 commit into from
Mar 1, 2022

Conversation

clonker
Copy link
Member

@clonker clonker commented Mar 1, 2022

  • LRU cache now depends on hash over the first MB of data as well as last modified and creation dates.
  • began enabling pathlib.Path objects for source/load

fixes issue #1541

@clonker clonker requested a review from thempel March 1, 2022 12:49
Copy link
Member

@thempel thempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #1545 (f5d0531) into devel (8c2bc84) will decrease coverage by 0.01%.
The diff coverage is 98.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel    #1545      +/-   ##
==========================================
- Coverage   92.07%   92.06%   -0.02%     
==========================================
  Files         229      229              
  Lines       26886    26920      +34     
==========================================
+ Hits        24756    24784      +28     
- Misses       2130     2136       +6     
Impacted Files Coverage Δ
pyemma/coordinates/data/util/traj_info_cache.py 92.41% <83.33%> (-0.60%) ⬇️
pyemma/coordinates/api.py 88.11% <100.00%> (ø)
pyemma/coordinates/data/feature_reader.py 95.60% <100.00%> (+0.10%) ⬆️
...yemma/coordinates/data/featurization/featurizer.py 89.77% <100.00%> (+0.04%) ⬆️
pyemma/coordinates/data/h5_reader.py 96.15% <100.00%> (+0.06%) ⬆️
pyemma/coordinates/data/numpy_filereader.py 96.66% <100.00%> (+0.05%) ⬆️
pyemma/coordinates/data/py_csv_reader.py 87.73% <100.00%> (+0.11%) ⬆️
pyemma/coordinates/data/util/reader_utils.py 88.03% <100.00%> (+0.20%) ⬆️
pyemma/coordinates/tests/test_traj_info_cache.py 98.60% <100.00%> (+0.09%) ⬆️
pyemma/coordinates/util/patches.py 86.40% <100.00%> (+0.06%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c2bc84...f5d0531. Read the comment docs.

@clonker clonker merged commit f6a7a7d into markovmodel:devel Mar 1, 2022
@clonker clonker deleted the cache_fix branch March 1, 2022 15:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants