Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider matching repository layout needed for HACS #35

Closed
zlalanne opened this issue Jun 30, 2019 · 4 comments
Closed

Consider matching repository layout needed for HACS #35

zlalanne opened this issue Jun 30, 2019 · 4 comments

Comments

@zlalanne
Copy link
Contributor

The HACS project allows you to install and manage custom components. There is a blueprint of what the repository layout should look like.

@webdjoe
Copy link
Owner

webdjoe commented Jul 1, 2019

Wow that's a really cool add-on, thanks for the tip. I'm trying to make this component an integration that uses the config flow in the frontend, which can't be done with custom components. So you won't need to put your login info in configuration.yaml. I pretty much have it done, just putting some finishing touches. I should have a PR with HA shortly:
image
image

@zlalanne
Copy link
Contributor Author

zlalanne commented Jul 1, 2019

So long term this is meant to be updated in Home Assistant and not live as a custom component?

@webdjoe
Copy link
Owner

webdjoe commented Jul 1, 2019

Yes it will be built-in HA, should hopefully have a PR out soon. There is a Vesync component already built-in but it's an older version with support for only a few of the original devices

@webdjoe
Copy link
Owner

webdjoe commented Jul 4, 2019

PR submitted to HA - home-assistant/core#24953

@webdjoe webdjoe closed this as completed Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants