New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for VeSync Devices - Outlets and Switches #24953
Conversation
Tests for the config flow is required. |
Do I just have to test the config flow or the whole integration? |
Tests for the config flow (if used) is the minimal requirement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Please add to the breaking change paragraph what the user needs to do to cope with the breaking change. |
Thanks for your patience in guiding me through this, I have a much better grip on the HA architecture! |
Thanks for the feedback! PR can be merged when build passes. |
Breaking Change:
Vesync integration is now a complete component, cannot be setup by individual platforms (i.e. switch). In addition to adding the Vesync component through configuration.yaml, it can also be added through the integration menu in the configuration UI.
The Vesync component no longer supports this syntax in configuration.yaml:
If using It must be set up using vesync as a component:
Description:
Convert VeSync switch platform to a full component. Can be configured through the integration menu in the configuration front-end or through configuration.yaml. Add support for the European 10 Amp smart outlet (ESW10-EU), US 15 Amp rectangular outlet (ESW15-USA), US 10 Amp round outlet (ESW10-USA), two plug outdoor outlet (ESO15-TB) and in wall switch (ESWL01).
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9779
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest
.requirements_all.txt
by runningpython3 -m script.gen_requirements_all
..coveragerc
.If the code does not interact with devices: