This repository has been archived by the owner on Nov 7, 2019. It is now read-only.
Use axisLabelColour (if set) for html labels, or omit inline css color #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markrcote
pushed a commit
that referenced
this pull request
May 4, 2014
Use axisLabelColour (if set) for html labels, or omit inline css color
|
Good point. Thanks! |
|
Actually, I decided to remove that line altogether. Everything else (font family, size, etc.) is configurable via CSS, so there's no point in having an explicit option for colour (plus plain HTML mode doesn't support it). Regardless, thanks for getting me thinking about it. :) I added you to the list of contributors. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTML labels are currently hardcoded to use
this.opts.color, which is used by flot for colouring gridlines. Since this is set as inline css, it's impossible to override with a stylesheet (using eg.axisLabels {color: black;}) and effectively means that the axis labels have to be the same colour as the gridlines.This should probably use
this.opts.axisLabelColourif it's been set, and otherwise omit the inlinecolordeclaration so that some global style can be applied.Specifically the line
should be replaced with something like