Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribution naming and namespaces #15

Closed
Beakerboy opened this issue Jul 21, 2016 · 3 comments
Closed

Distribution naming and namespaces #15

Beakerboy opened this issue Jul 21, 2016 · 3 comments

Comments

@Beakerboy
Copy link
Contributor

It looks like there are both continuous and discrete uniform interval distributions....which looks like a problem than be solved my either class naming standards, or namespacing. Would you prefer a Math\Probability\Distribution\Continuous and Discrete namespaces, or just keep everything in Distribution?

On a similar vein, do you think all the classes and files need to have 'Distribution' in their names? Would things be cleaner to just have 'StandardNormal.php'?

@markrogoyski
Copy link
Owner

Two separate namespaces:
Math\Probability\Distribution\Continuous
Math\Probability\Distribution\Discrete

And since they are under a Distribution namespace, there is no need to put Distribution in any of the class names.

Then each can also have a unique base class to inherit from, since Continuous would have a PDF method, and a Discrete would have a pmf method, etc.

@Beakerboy
Copy link
Contributor Author

Done in the Distribution pull request.

@Beakerboy
Copy link
Contributor Author

The Discrete classes have been moved as well. There's a pull request for it.

markrogoyski pushed a commit that referenced this issue Aug 11, 2016
markrogoyski pushed a commit that referenced this issue Jun 9, 2017
* Create Boolean.php

* Create BooleanTest.php

* Rename (#15)

* Create Bitwise.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants