Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter range in functions #57

Closed
Beakerboy opened this issue Aug 10, 2016 · 2 comments
Closed

Parameter range in functions #57

Beakerboy opened this issue Aug 10, 2016 · 2 comments
Labels

Comments

@Beakerboy
Copy link
Contributor

Should we move the error-checking function so it can be used by other functions throughout the library?

@markrogoyski
Copy link
Owner

I thought about that. It makes sense in the distributions because all the methods are related and use the same parameters. But a lot of the other classes are collections of functions that don't necessarily share the parameters. So, each method would also have to define the limits parameter when it calls the checkLimits method. Not a big deal, but not as convenient as just passing a common limits constant. I think maybe in \Math\Functions having a class for internal helper functions might be a good idea. That's already where Map lives.

@markrogoyski
Copy link
Owner

Moved to Math\Functions\Support.

markrogoyski pushed a commit that referenced this issue Sep 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants