Skip to content

Commit

Permalink
intermediate version that partially fixes tainted upload problems
Browse files Browse the repository at this point in the history
  • Loading branch information
lstein committed Mar 18, 1999
1 parent 9e134c5 commit 55acea9
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 4 deletions.
7 changes: 5 additions & 2 deletions CGI.pm
Expand Up @@ -17,7 +17,7 @@ require 5.004;
# The most recent version and complete docs are available at:
# http://stein.cshl.org/WWW/software/CGI/

$CGI::revision = '$Id: CGI.pm,v 1.10 1999-03-11 04:16:26 lstein Exp $';
$CGI::revision = '$Id: CGI.pm,v 1.11 1999-03-18 01:36:22 lstein Exp $';
$CGI::VERSION='2.50';

# HARD-CODED LOCATION FOR FILE UPLOAD TEMPORARY FILES.
Expand Down Expand Up @@ -2261,6 +2261,9 @@ sub expire_calc {
my($offset);
if (!$time || (lc($time) eq 'now')) {
$offset = 0;
} elsif ($time=~/^\d+/)
return $time;
}
} elsif ($time=~/^([+-]?(?:\d+|\d*\.\d*))([mhdMy]?)/) {
$offset = ($mult{$2} || 1)*$1;
} else {
Expand Down Expand Up @@ -2377,8 +2380,8 @@ sub query_string {
foreach $param ($self->param) {
my($eparam) = escape($param);
foreach $value ($self->param($param)) {
next unless defined $value;
$value = escape($value);
next unless defined $value;
push(@pairs,"$eparam=$value");
}
}
Expand Down
9 changes: 7 additions & 2 deletions cgi_docs.html
Expand Up @@ -4526,7 +4526,12 @@ <H2><a name="bugs">Bug Reports</a></H2>
<HR>

<H2><A NAME="new">Revision History</A></H2>

<h3>Version 2.50</h3>
<ol>
<li>Untainted tainted tempfile name so that script doesn't fail on terminal unlink
<li>Made picking of upload tempfile name more intelligent so that doesn't fail in case of name collision.
<li>Fixed handling of expire times when passed an absolute timestamp.
</ol>
<h3>Version 2.49</h3>
<ol>
<li>Fixes for FastCGI (globals not getting reset)
Expand Down Expand Up @@ -5194,6 +5199,6 @@ <H3>Bug fixes</H3>
<a href="http://www.cshl.org/">Cold Spring Harbor Laboratory</a></ADDRESS>
<P>
<!-- hhmts start -->
Last modified: Tue Mar 9 10:31:49 EST 1999
Last modified: Thu Mar 11 16:18:45 EST 1999
<!-- hhmts end -->
</BODY> </HTML>

0 comments on commit 55acea9

Please sign in to comment.