Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACP Rule URL - Question #18

Open
banzigaga opened this issue Jun 12, 2019 · 8 comments
Open

ACP Rule URL - Question #18

banzigaga opened this issue Jun 12, 2019 · 8 comments

Comments

@banzigaga
Copy link

Hello,

Is there a way to add an URL to an ACPRule?

Regards,

Gabor

@parkerbrother1
Copy link
Collaborator

@banzigaga
Yes, but right now you have to build it manually. Eventually I will add a function in the ACPRule Class which takes a list of url object names and does the work for you, just like the other supported objects.

url1 = URL(fmc=fmc1, name='_url1', url='asdf.org')
url1.post()
foo = [{"type":url1.type,"id":url1.id,"name":url1.name}]
acprule1 = ACPRule(fmc=fmc1, acp_name=acp1.name)
acprule1.urls = {"objects":foo}

@banzigaga
Copy link
Author

Ok, thanks @parkerbrother1 !

@daxm
Copy link
Collaborator

daxm commented Aug 25, 2019

@parkerbrother1 have you made any progress on this?
Personally I like the separate method as it keeps things simple and the script writer doesn't need to be a programmer and/or need to know the underlying structure of the "objects" format.

@NetDevAutomate
Copy link

NetDevAutomate commented Aug 25, 2019 via email

@daxm
Copy link
Collaborator

daxm commented Sep 13, 2019

@karmicgeezer,
Or post your code here and I can implement it.

@banzigaga
Copy link
Author

Hello, just asking how about this enhancement?

@daxm
Copy link
Collaborator

daxm commented Mar 19, 2020

@NetDevAutomate, any status on your "fix" for this?

@daxm
Copy link
Collaborator

daxm commented Jun 15, 2020

Check out the release 20200615.0. I believe we've finally integrated the URL addition into the AccessRule class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants