Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update bleach to version >5.0.0 #55

Merged
merged 4 commits into from May 16, 2022

Conversation

Laityned
Copy link
Contributor

@Laityned Laityned commented May 13, 2022

Description

Update bleach to new major version

Describe:

Update the dependency bleach to next major version.
For backward compatibility allowed_styles is still a keyword argument on all functions. This argument will be replaced by css_sanitizer.
Allowed_styles should be deprecated in the near feature in order to still comply with same function arguments as bleach. This should be included in the next major release.

References

Checklist

  • I have ran tox to ensure tests pass
  • Usage documentation added in case of new features
  • Tests added / I have not lowered coverage from 100%

@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #55 (14050ab) into main (34ab359) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #55   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           86       100   +14     
  Branches        19        23    +4     
=========================================
+ Hits            86       100   +14     
Impacted Files Coverage Δ
forms.py 100.00% <0.00%> (ø)
models.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34ab359...14050ab. Read the comment docs.

Copy link
Owner

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this @Laityned - especially doing things properly with the warnings!

@marksweb marksweb merged commit 1c80b32 into marksweb:main May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants