re-enable the content-check of validate

[devfaz]

6 years ago the commit a26a8a1 disabled the content-check of validate.

The module just checked if a connection is possible, but doesnt check if f.e. WSREP is ready.
This commit fixes this by re-adding the grep-call

[fraenki]

for reference:
a26a8a1

[fraenki]

@devfaz Thanks for your contribution! However, it looks like it was changed for a reason. Could you elaborate more on why you think it should be changed (again)? What would be improved? What are the risks?

On which database vendor + version has this been tested?

[devfaz]

@fraenki according to the commit msg. This was done to "optimize" the code by using retry, sleep of puppet instead of bash-code.
Seems like a typical "i dont like this code, i optimize it - oh did test it well - now its broken"-workflow.

What would be improved? Well it works again? The code currently isnt working at all, because its no longer looking for "truecatch" and so it just checks if connection is possible (without checking if wsrep is ready)

This is not the latest version of my fix, so plz hold the line - I will update the commit asap.

[fraenki]

This is not the latest version of my fix, so plz hold the line - I will update the commit asap.

Sure, waiting for your updated fix.

[fraenki]

@devfaz I'm currently preparing version 2.0.0 of this module. I think this change would suit well in this major release, because it already contains several breaking changes.

[fraenki]

@devfaz I know the current situation is not ideal, but may I ask you to rebase your PR against the current master? Thanks!

[devfaz]

@fraenki - I just rebased my change. In the meantime I found out, that my previous try to workaround the "ERROR"-detection wasnt working in every edge-case, but the topic of this issue is solved by this commit.

I will create another issue for the "ERR"-detection issue.

[fraenki]

@devfaz Merged, thanks!

[fraenki]

Released as 2.1.0.