Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add FreeBSD support, use module data #1

Merged
merged 1 commit into from Jan 29, 2018
Merged

add FreeBSD support, use module data #1

merged 1 commit into from Jan 29, 2018

Conversation

fraenki
Copy link
Member

@fraenki fraenki commented Jan 28, 2018

  • Add support for the FreeBSD operating system
  • Replace params.pp with module data
  • Update metadata.json to reflect current state of this module
  • Small updates to README.md: remove unused section, add hint for postfix on CentOS
  • Update copyright/authors information
  • Small style fixes

I'd suggest to release a new version if you decide to accept this PR :)

@fraenki fraenki changed the title add FreeBSD support add FreeBSD support, use module data Jan 28, 2018
@oxc oxc merged commit 03dc8f8 into markt-de:master Jan 29, 2018
@oxc
Copy link
Collaborator

oxc commented Feb 5, 2018

@fraenki there is no mailx package on Ubuntu 16.04, this is only a virtual package.

Package mailx is a virtual package provided by:
s-nail 14.8.6-1
mailutils 1:2.99.99-1ubuntu2
bsd-mailx 8.1.2-0.20160123cvs-2

I do not like the default configuration raise an error here. Looks like before, the module selected bsd-mailx. Can you add some Debian-specific config to reflect the previous state?

See https://github.com/oxc/puppet-postfix/pull/1/files#r166102379

Since we don't need/want to support ancient Debian versions, I believe choosing bsd-mailx as default for Debianoids is fine, do you agree?


$mailx_package = $::lsbdistcodename ? {
/sarge|etch|lenny/ => 'mailx',
default => 'bsd-mailx',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selecting bsd-mailx on newer versions got lost in the change.

oxc added a commit that referenced this pull request Feb 5, 2018
oxc added a commit that referenced this pull request Feb 5, 2018
@oxc
Copy link
Collaborator

oxc commented Feb 5, 2018

I'd suggest to release a new version if you decide to accept this PR :)

0.2.1 is now on puppet forge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants