Systemd service file PIDFile mismatch #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new pidfile value, default set to "SonarQube.pid"
|
Merged, thanks! PS: The "stealth" LDAP change would have been better suited in a new PR. I've merged it anyway, but overall using one PR for every contribution (and not mixing multiple topics in a PR) makes review much easier. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I came from the maestrodev/sonarqube module, and I'm currently using SonarQube 8.5.1. I know it's old, and I'm looking to upgrade to LTS first, then latest. But since the maestrodev module isn't maintained anymore, I thought I first upgrade to this module.
When I changed to using this module and keeping the 8.5.1 version, I had an issue with the PID file in the SonarQube home directory. The PID file is created, but it is called
sonar.pid, and the Systemd service file is looking forSonarQube.pid.SonarQube does start and works, for a short time, but then Systemd times out because it can't find the PID file, and it then terminates SonarQube.
This PR adds a pidfile parameter defaulting to "SonarQube.pid" (which is currently the fixed filename), making us able to configure which PIDFile that Systemd should use if there is a mismatch.