Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Has to drag images to the edit area #1207

Closed
1 task done
SuperAllenYao opened this issue Jul 31, 2019 · 8 comments
Closed
1 task done

Has to drag images to the edit area #1207

SuperAllenYao opened this issue Jul 31, 2019 · 8 comments
Labels
🦄 feature request New feature or request

Comments

@SuperAllenYao
Copy link

SuperAllenYao commented Jul 31, 2019

Description

  • Can you reproduce the issue?

Steps to reproduce

  1. [First step] open a file
  2. [Second step] drag an image to Mark Text window
  3. [and so on...]

Expected behavior: image inserted

Actual behavior: image not inserted

Link to an example: [optional]
It has to drag the images to the editor area, and then images successfully insert into the file.

Versions

  • Mark Text: 0.15.0-rc2
  • Operating system: macOS 10.14.6
@SuperAllenYao SuperAllenYao changed the title Insert images has to darg Has to drag images to the edit area Jul 31, 2019
@liziqiang
Copy link
Contributor

expect this feature too~

@Jocs
Copy link
Member

Jocs commented Jul 31, 2019

@liziqiang The new version will support drag and insert image before/after paragraph.

@fxha
Copy link
Contributor

fxha commented Jul 31, 2019

The problem with "just" insert an image is the position we should insert the image. The current solution as of v0.15.x is to allow the user to select a paragraph to insert to while dropping. Another option would be the last cursor position but inline images are currently not supported (#1094). I think the current solution is currently sufficient?

@Jocs
Copy link
Member

Jocs commented Jul 31, 2019

Another option would be the last cursor position but inline images are currently not supported (#1094). I think the current solution is currently sufficient?

At present, it is enough, because we now have the image on block display instead of inline. After adding the inline image, add the drag and drop to insert it into the specified cursor.

@fxha
Copy link
Contributor

fxha commented Aug 10, 2019

What's the status of this issue. Dragging the image to an undefined position is undefined and so this is the expected behavior?! @SuperAllenYao Could you please explain what you expect when dragging the image outside the editor area?

@fxha fxha added the 🦁 need discuss the issue or PR need to discuss label Aug 10, 2019
@SuperAllenYao
Copy link
Author

SuperAllenYao commented Aug 10, 2019 via email

@fxha fxha added 🛑 blocked This issue or PR is blocked by other issue 🦄 feature request New feature or request and removed 🦁 need discuss the issue or PR need to discuss labels Aug 12, 2019
@fxha
Copy link
Contributor

fxha commented Aug 12, 2019

Blocked due #1094.

@fxha fxha removed the 🛑 blocked This issue or PR is blocked by other issue label Oct 26, 2019
@fxha
Copy link
Contributor

fxha commented Oct 26, 2019

Closing the issue because you can insert the image before or after a paragraph in v0.16.0.

@fxha fxha closed this as completed Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦄 feature request New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants