Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font size settings for titles #1224

Closed
adrienbeau opened this issue Aug 2, 2019 · 7 comments · Fixed by #2135
Closed

Font size settings for titles #1224

adrienbeau opened this issue Aug 2, 2019 · 7 comments · Fixed by #2135
Assignees
Labels
🦋 optimization Improve the existing behavior 🦄 feature request New feature or request

Comments

@adrienbeau
Copy link

Feature request description

Currently (version 0.15.0-rc.3), Mark Text has font size settings for the editor text and code block text. However these settings do not affect the title font sizes in any way. In particular, using a smaller size results in titles that look awfully big.

It should be possible to set the title sizes. Having separate settings for each title level might be too much, but deriving the various sizes from one master setting would be nice.

Alternatively, there could be a "zoom" setting for the whole editor, which would affect all font sizes proportionately.

What problem does this feature solve?

The title sizes are not harmonious compared to the body text size.

@fxha
Copy link
Contributor

fxha commented Aug 2, 2019

Thanks for reporting this issue. Indeed this need an improvement and the font size should affect all text content or the user should be able to control the different text sizes. You can find a zoom in/out under the View menu - but currently broken due an upstream issue.

@fxha fxha added 🦄 feature request New feature or request 🦋 optimization Improve the existing behavior labels Aug 2, 2019
@Jocs Jocs self-assigned this Sep 29, 2019
@Jocs Jocs added this to TO-DO in 0.16.0 Sep 29, 2019
@Jocs Jocs removed this from TO-DO in 0.16.0 Oct 26, 2019
@HemaKanakamedala
Copy link

I have found a solution for this and it worked. Can i be a part of this?

@Jocs
Copy link
Member

Jocs commented Nov 17, 2019

I have found a solution for this and it worked. Can i be a part of this?

Can you explain your solution here first?

@fxha
Copy link
Contributor

fxha commented Nov 17, 2019

@HemaKanakamedala @Jocs I guess we could use heading font sizes in em to automatically adjust to the default font size.

@HemaKanakamedala
Copy link

Yes @fxha . I have done the same thing. I have calculated the corresponding px size into em. That helped for the resizing of titles and headings also

@Jocs
Copy link
Member

Jocs commented Nov 18, 2019

I guess we could use heading font sizes in em to automatically adjust to the default font size.

Yes, that's a good solution, so we only to set the font size at the root element of editor.

@renehummen
Copy link

Mark Text is a great editor to handle my To-Do lists. Just the default font sizes are a bit too large for my purposes and when trying to decrease the font size via the preferences, I stumbled across the same issue. I am currently on Mark Text v0.16.0-rc.2.

@HemaKanakamedala Did you already make a PR for this issue as you seem to have figured out an appropriate solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦋 optimization Improve the existing behavior 🦄 feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants