Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception when deleting code block identifier #1231

Closed
1 task done
fxha opened this issue Aug 4, 2019 · 0 comments
Closed
1 task done

Exception when deleting code block identifier #1231

fxha opened this issue Aug 4, 2019 · 0 comments
Assignees
Labels
🔭 area/muya 🐛 bug Something isn't working :octocat: code block issues about code block
Projects

Comments

@fxha
Copy link
Contributor

fxha commented Aug 4, 2019

Description

An exception occurs when deleting the code block identifier and pressing multiple backspace after.

  • Can you reproduce the issue?

Steps to reproduce

  1. Create a code block like below (without \)
  2. Remove cpp and press multiple backspaces when your removed cpp
foo

\```cpp
foo
bar
\```

baz

Stack Trace:

exportMarkdown.js:228 Uncaught TypeError: Cannot read property 'children' of undefined
    at ds.normalizeCodeBlock (exportMarkdown.js:228)
    at ds.translateBlocks2Markdown (exportMarkdown.js:146)
    at ds.generate (exportMarkdown.js:31)
    at rr.getMarkdown (index.js:123)
    at rr.Br.dispatchChange (index.js:100)
    at keyboard.js:89

Versions

  • Mark Text: v0.15.0 (release draft) - commit e2bac53
  • Operating system: all
@fxha fxha added 🐛 bug Something isn't working :octocat: code block issues about code block 🔭 area/muya labels Aug 4, 2019
@Jocs Jocs self-assigned this Sep 26, 2019
@Jocs Jocs added this to TO-DO in 0.16.0 Sep 26, 2019
@Jocs Jocs moved this from TO-DO to In Progress in 0.16.0 Sep 27, 2019
@Jocs Jocs moved this from In Progress to Review in 0.16.0 Sep 27, 2019
@Jocs Jocs moved this from Review to Done in 0.16.0 Sep 30, 2019
@Jocs Jocs closed this as completed Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔭 area/muya 🐛 bug Something isn't working :octocat: code block issues about code block
Projects
No open projects
0.16.0
  
Done
Development

No branches or pull requests

2 participants