Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTRL/CMD+SHIFT+F opens sidebar and focuses on "search in folder" #1311

Closed
Illyism opened this issue Sep 1, 2019 · 5 comments
Closed

CTRL/CMD+SHIFT+F opens sidebar and focuses on "search in folder" #1311

Illyism opened this issue Sep 1, 2019 · 5 comments
Labels
🦄 feature request New feature or request 🐳 help wanted Extra attention is needed
Projects

Comments

@Illyism
Copy link
Contributor

Illyism commented Sep 1, 2019

Describe your feature request

  • You have CTRL/CMD+F now to start search in the current file
  • We could add a keyboard shortcut to search through all files
  • When a word or sentence is selected it should pre-fill the search query with the selected text
@Jocs
Copy link
Member

Jocs commented Sep 2, 2019

Another point to note is that if there is no opened folder, this shortcut needs to be disabled and the menu item will be grayed out(disabled).

@Jocs Jocs added 🦄 feature request New feature or request 🐳 help wanted Extra attention is needed labels Sep 2, 2019
@Illyism
Copy link
Contributor Author

Illyism commented Sep 2, 2019

Also, the search keyword is reset when the search container is mounted. I think this should be remembered in vuex / storage.

And the input should get focus and the value should be selected.

@tongphe
Copy link

tongphe commented Sep 5, 2019

I also recommend using ESC to unfocus search box and focus back on file sidebar/tab

@Jocs Jocs added this to TO-DO in 0.16.0 Sep 29, 2019
@Jocs Jocs moved this from TO-DO to In Progress in 0.16.0 Sep 30, 2019
@Jocs Jocs moved this from In Progress to TO-DO in 0.16.0 Sep 30, 2019
@Jocs Jocs moved this from TO-DO to In Progress in 0.16.0 Oct 26, 2019
@Jocs Jocs moved this from In Progress to Review in 0.16.0 Oct 26, 2019
@Jocs Jocs moved this from Review to Done in 0.16.0 Oct 26, 2019
@Jocs Jocs closed this as completed Oct 26, 2019
@ianhinder
Copy link

Thanks for implementing. This would be much more useful if the focus was also transferred to the search box. As far as I can tell, if I want to search, I hit Cmd-Shift-F, and then have to click in the search box in order to type. I'd like to do all this from the keyboard. Should I open a new issue?

@Jocs
Copy link
Member

Jocs commented Feb 23, 2020

Thanks for implementing. This would be much more useful if the focus was also transferred to the search box. As far as I can tell, if I want to search, I hit Cmd-Shift-F, and then have to click in the search box in order to type. I'd like to do all this from the keyboard. Should I open a new issue?

Please open a new issue about your description, it's a new feature, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦄 feature request New feature or request 🐳 help wanted Extra attention is needed
Projects
No open projects
0.16.0
  
Done
Development

No branches or pull requests

4 participants