Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image is missing if change to source code mode #1337

Closed
1 task done
linvis opened this issue Sep 12, 2019 · 4 comments
Closed
1 task done

image is missing if change to source code mode #1337

linvis opened this issue Sep 12, 2019 · 4 comments
Assignees
Labels
🐛 bug Something isn't working
Projects

Comments

@linvis
Copy link

linvis commented Sep 12, 2019

Description

  • Can you reproduce the issue?

Steps to reproduce

  1. [First step] in normal mode, paste an image from clipboard, image show normally.
  2. [Second step] after paste, change to source code mode immediately, it show
![loading-ag-70]()
  1. [and so on...] cancel source code mode, change to normal mode, image missing,
    image

Expected behavior:
image should not miss

Actual behavior:
miss

Link to an example: [optional]

Versions

  • Mark Text:v0.15.0
  • Operating system: mac OS mojave 10.14.4
@linvis
Copy link
Author

linvis commented Sep 12, 2019

but if I change to source code mode after a few seconds in second step, image is not missing.

@Jocs
Copy link
Member

Jocs commented Sep 12, 2019

but if I change to source code mode after a few seconds in second step, image is not missing.

Yes, the image maybe is uploading, where do you put your images?

@linvis
Copy link
Author

linvis commented Sep 13, 2019

but if I change to source code mode after a few seconds in second step, image is not missing.

Yes, the image maybe is uploading, where do you put your images?

using option:

insert absolute or relative path of image, and I choose a local folder.

@fxha
Copy link
Contributor

fxha commented Sep 20, 2019

@Jocs The issue occurs if you use absolute or relative path image settings, insert the image and switch to source code mode immediately. The operation is done asynchrony and never completed because the view is switched before.

@fxha fxha added the 🐛 bug Something isn't working label Sep 20, 2019
@Jocs Jocs self-assigned this Sep 26, 2019
@Jocs Jocs added this to TO-DO in 0.16.0 Sep 26, 2019
@Jocs Jocs moved this from TO-DO to In Progress in 0.16.0 Sep 27, 2019
@Jocs Jocs moved this from In Progress to Review in 0.16.0 Sep 27, 2019
@Jocs Jocs closed this as completed Oct 1, 2019
@Jocs Jocs moved this from Review to Done in 0.16.0 Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
No open projects
0.16.0
  
Done
Development

No branches or pull requests

3 participants