Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlink would not render when it's in footnote. #1552

Closed
1 task done
atodniAr opened this issue Oct 27, 2019 · 5 comments
Closed
1 task done

Hyperlink would not render when it's in footnote. #1552

atodniAr opened this issue Oct 27, 2019 · 5 comments
Labels
🦁 need discuss the issue or PR need to discuss

Comments

@atodniAr
Copy link

Description

  • Can you reproduce the issue?

Steps to reproduce

  1. Create a footnote, say ^[1] somewhere in text, and [1]: at the end of the content.
  2. Create a normal hyperlink, it would not render

Expected behavior:

Rendered as hyperlink.

Actual behavior:

Not rendering, like this:

Versions

  • Mark Text: 0.15.1
  • Operating system: macOS Catalina

Similar on my win 10 with Mark Text 0.14.0

@Jocs
Copy link
Member

Jocs commented Oct 28, 2019

@atodniAr This will be support in the coming of version 0.16.0, and even support multiple paragraphs in footnote definition. BTY, the footnote definition syntax is [^footnote]: abc? and [footnote]: abc is reference link/image definition.

@Jocs Jocs added the 🦁 need discuss the issue or PR need to discuss label Oct 28, 2019
@Fastidious
Copy link

@Jocs is this on 0.16.0 RC.1? The syntax you are referring isn't working on me on the RC.1. Something that quasi works is [^footnote] and [^footnote]: abc for the link to it. I say quasi work, because the rendering looks odd. See below.

Screenshot 2019-11-12 at 13 05 36

And the source:

Screenshot 2019-11-12 at 13 06 05

@fxha
Copy link
Contributor

fxha commented Nov 12, 2019

@Fastidious Footnotes are disabled by default, please enable Pandoc footnotes in settings under Markdown -> Markdown extension syntax.

@Jocs
Copy link
Member

Jocs commented Nov 17, 2019

closed due to footnote is already implemented in v0.16.0. feel free to reopen it, if you have any question.

@Jocs Jocs closed this as completed Nov 17, 2019
@adrienbeau
Copy link

I just tested this in 0.16.0-rc1. Footnotes work fine when the extension is enabled in the settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦁 need discuss the issue or PR need to discuss
Projects
None yet
Development

No branches or pull requests

5 participants