Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong shortcut symbols in block list #1635

Closed
1 task done
Lisiadito opened this issue Nov 6, 2019 · 8 comments
Closed
1 task done

Wrong shortcut symbols in block list #1635

Lisiadito opened this issue Nov 6, 2019 · 8 comments
Labels
🦋 optimization Improve the existing behavior 🦉 pre-release
Projects

Comments

@Lisiadito
Copy link
Contributor

Description

When adding a block by typing @ I get shown the shortcuts for a Mac keyboard even tough I'm using the AppImage for Linux.
image

  • Can you reproduce the issue?

Steps to reproduce

  1. Type @

Expected behavior:

I expect to see the correct shortcuts for my OS.

Actual behavior:

I see the wrong shortcuts.

Versions

  • Mark Text: v0.15.0
  • Operating system: Linux Mint Mate 18.3
@Jocs
Copy link
Member

Jocs commented Nov 7, 2019

@Lisiadito I got the shortcuts like bellow on macOS:

截屏2019-11-07下午7 08 50

@fxha can you help check whether it's wrong?

@Jocs Jocs added the 🐤 blocked/need info Need more details about this issue or pull request label Nov 7, 2019
@fxha
Copy link
Contributor

fxha commented Nov 7, 2019

@Jocs These are macOS shortcuts, so they may confusing to non macOS users because they don't know what the symbols mean.

@Jocs
Copy link
Member

Jocs commented Nov 7, 2019

These are macOS shortcuts, so they may confusing to non macOS users because they don't know what the symbols mean.

i don't know the what's the look like of shortcuts on Linux and Windows, so can you submit a PR when you are convenient?

@Jocs Jocs self-assigned this Nov 7, 2019
@Jocs Jocs added 🦋 optimization Improve the existing behavior and removed 🐤 blocked/need info Need more details about this issue or pull request labels Nov 7, 2019
@Jocs Jocs assigned fxha and unassigned Jocs Nov 7, 2019
@fxha
Copy link
Contributor

fxha commented Nov 7, 2019

These are macOS shortcuts, so they may confusing to non macOS users because they don't know what the symbols mean.

i don't know the what's the look like of shortcuts on Linux and Windows, so can you submit a PR when you are convenient?

I guess Ctrl, Alt and Shift directly?

@fxha fxha removed their assignment Nov 7, 2019
@Lisiadito
Copy link
Contributor Author

In the menu you can see the correct shortcuts.
If you can give me an hint where I need to look to fix that I'm glad to open a PR
image

@Lisiadito
Copy link
Contributor Author

Lisiadito commented Nov 7, 2019

ok I think I found where they are specified.
src/muya/lib/ui/quickInsert/config.js
If you're fine with it I will see if I can fix it and open a PR.

Another question would be if we want to use ^ as a symbol for ctrl as it is already in use or use the word ctrl instead?

@Jocs
Copy link
Member

Jocs commented Nov 7, 2019

@Lisiadito PR is welcome, you can use isMac and isWin in the folder.

截屏2019-11-07下午8 19 12

@Jocs
Copy link
Member

Jocs commented Nov 7, 2019

Another question would be if we want to use ^ as a symbol for ctrl as it is already in use or use the word ctrl instead?

I think you can the word in the menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦋 optimization Improve the existing behavior 🦉 pre-release
Projects
No open projects
0.16.0
  
Done
Development

No branches or pull requests

3 participants