Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headings containing shorthand emojis won't allow "Exporting to PDF / HTML" #1738

Closed
1 task done
naivros opened this issue Nov 22, 2019 · 1 comment 路 Fixed by #1759
Closed
1 task done

Headings containing shorthand emojis won't allow "Exporting to PDF / HTML" #1738

naivros opened this issue Nov 22, 2019 · 1 comment 路 Fixed by #1759
Labels
馃敪 area/muya 馃悰 bug Something isn't working
Projects

Comments

@naivros
Copy link

naivros commented Nov 22, 2019

Description

Using the shorthand emoji names (":angry聽:") within a header forces the application to refuse exporting silently; however, copying and pasting Unicode-8 emojis from an online repository (馃檭) into the heading, allows exporting, as expected.

  • Can you reproduce the issue?

Steps to reproduce

**Note the &nbsp character, to not render such shorthand names in this bug report.

  1. Create new Note
  2. Insert: :angry聽:
  3. Ctrl+[1-6]: To make the line a heading.
  4. File > Export > HTML or PDF

Expected behavior:

Successful exporting to a file, with a prompt requesting save location, or at least an error.

Actual behavior:

Nothing. Menu closes silently.

unexpected

Versions

  • Mark Text: v0.15.1
  • Operating system: Windows 10 Pro
@fxha
Copy link
Contributor

fxha commented Nov 24, 2019

Stack Trace:

[error] Failed to export document: TypeError: this.renderer.emoji is not a function
Please report this to https://github.com/marktext/marktext/issues.
    at Lr.output (webpack:/src/muya/lib/parser/marked/inlineLexer.js:186:30)
    at Or.tok (webpack:/src/muya/lib/parser/marked/parser.js:95:34)
    at Or.parse (webpack:/src/muya/lib/parser/marked/parser.js:39:17)
    at marked (webpack:/src/muya/lib/parser/marked/index.js:22:28)
    at wa.renderHtml (webpack:/src/muya/lib/utils/exportHtml.js:108:16)
    at wa.generate (webpack:/src/muya/lib/utils/exportHtml.js:177:47)
    at cc.exportStyledHTML (webpack:/src/muya/lib/index.js:152:43)
    at s.apply (webpack:/src/renderer/components/editorWithTabs/editor.vue:949:1)
    at invokeWithErrorHandling (webpack:/node_modules/vue/dist/vue.esm.js:1863:26)
    at ft.A.$emit (webpack:/node_modules/vue/dist/vue.esm.js:3891:9)

@fxha fxha added 馃悰 bug Something isn't working 馃敪 area/muya labels Nov 24, 2019
@fxha fxha added this to TO-DO in 0.16.0 Nov 24, 2019
@Jocs Jocs moved this from TO-DO to Review in 0.16.0 Nov 25, 2019
@fxha fxha moved this from Review to Done in 0.16.0 Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
馃敪 area/muya 馃悰 bug Something isn't working
Projects
No open projects
0.16.0
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants